On 2/24/20 4:11 PM, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > It's weird that libxfs_init opens the three devices passed in via the > libxfs_xinit structure but libxfs_destroy doesn't actually close them. > Fix this inconsistency and remove all the open-coded device closing. Seems better. Part of me wishes the device open/close weren't hidden in init/destroy but from a quick glance that's harder to tease apart. Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>