On 2/24/20 2:30 PM, Christoph Hellwig wrote: > On Mon, Feb 24, 2020 at 02:27:49PM -0800, Eric Sandeen wrote: >> On 2/24/20 2:02 PM, Christoph Hellwig wrote: >>> On Thu, Jan 30, 2020 at 02:33:38PM +0100, Christoph Hellwig wrote: >>>> struct xfs_agfl is a header in front of the AGFL entries that exists >>>> for CRC enabled file systems. For not CRC enabled file systems the AGFL >>>> is simply a list of agbno. Make the CRC case similar to that by just >>>> using the list behind the new header. This indirectly solves a problem >>>> with modern gcc versions that warn about taking addresses of packed >>>> structures (and we have to pack the AGFL given that gcc rounds up >>>> structure sizes). Also replace the helper macro to get from a buffer >>>> with an inline function in xfs_alloc.h to make the code easier to >>>> read. >>>> >>>> Signed-off-by: Christoph Hellwig <hch@xxxxxx> >>> >>> Any chance we can pick this up for 5.6 to unbreak arm OABI? >>> >> >> What did I miss, where's the report of actual breakage vs. >> (I thought) harmless GCC complaints? > > The "harmless" gcc complaint is that the kernel build errors out as > soon as XFS is enabled on arm OABI. Which is a good thing, as the > file system would not be interoperable with other architectures if it > didn't. Not just on latest GCC? Ok, I just hadn't seen that reported (but, I miss lots). And the commit log doesn't mention any actual breakage; it sounds like patch to work around a new gcc warning, not an actual fix for anything real. -Eric
