On 2/23/20 6:04 AM, Amir Goldstein wrote:
On Sun, Feb 23, 2020 at 4:07 AM Allison Collins
<allison.henderson@xxxxxxxxxx> wrote:
To help pre-simplify xfs_attr_set_args, we need to hoist transacation handling up,
typo: transacation
Will fix :-)
while modularizing the adjacent code down into helpers. In this patch, hoist the
commit in xfs_attr_try_sf_addname up into the calling function, and also pull the
attr list creation down.
Signed-off-by: Allison Collins <allison.henderson@xxxxxxxxxx>
Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
---
And I don't think the subject (Refactoring) is a reliable description
of this change,
but if nobody else cares, I don't mind what you call it.
Yes, I struggled with that a bit since things are just generally being
re-arranged, but if there's a more descriptive term folks prefer, please
call it out.
As far as not changing logic, you may add:
Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx>
Thanks!
Allison
Thanks,
Amir.
