On Sun, Feb 23, 2020 at 4:07 AM Allison Collins <allison.henderson@xxxxxxxxxx> wrote: > > Factor out new helper function xfs_attr_leaf_try_add. Right. This should be the subject. Not factor out xfs_attr_leaf_addname helper. > Because new delayed attribute > routines cannot roll transactions, we carve off the parts of xfs_attr_leaf_addname > that we can use, and move the commit into the calling function. And that is a different change. It is hard enough to review a pure factor out of a helper. Adding changed inside a pure re-factor is not good. Belongs to another change - move transaction commit to caller. Thanks, Amir.
