On Thu, Feb 20, 2020 at 11:08 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Thu, Feb 20, 2020 at 11:06:10AM -0500, Stephen Smalley wrote: > > > The dquot_* routines are not generic quota code, but a specific > > > implementation used by most non-XFS file systems. So if there is a bug > > > it is that the security call is not in the generic dispatch code. > > > > Hmm...any reason the security hook call couldn't be taken to > > quota_quotaon()? > > I haven't touched the quota code for a while, but yes, the existing > calls should move to the quota_* routines in fs/quota/quota.c. Note > that you still need to add checks, e.g. for Q_XSETQLIM. Who wanted to submit a patch for this? Christoph were you planning on fixing this? If not, Richard, do you want to give it a try? -- paul moore www.paul-moore.com