On Fri, Feb 21, 2020 at 06:45:47AM -0800, Christoph Hellwig wrote: > On Wed, Feb 19, 2020 at 05:43:19PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > Make libxfs_bwrite equivalent to libxfs_writebufr. This makes it so > > that libxfs bwrite calls write the buffer to disk immediately and > > without double-freeing the buffer. However, we choose to consolidate > > around the libxfs_bwrite name to match the kernel. > > The commit message looks a little odd. Also why is the subject a > different style than the previous messages? Ok, changed to: "libxfs: rename libxfs_writebufr to libxfs_bwrite "Rename this function so that we have an API that matches the kernel without a #define." > Also if there was a double free shouldn't we fix that in a small > backportable patch first (not that I see such a fix anywhere)? Hmmm... I can't find one either. I think that's just an anachronism from an earlier version of this series. --D
