On Fri, Feb 21, 2020 at 06:45:22PM +0100, Christoph Hellwig wrote: > On Thu, Feb 20, 2020 at 04:41:31PM -0800, ira.weiny@xxxxxxxxx wrote: > > From: Ira Weiny <ira.weiny@xxxxxxxxx> > > > > Define a variable to hold the lock flags to ensure that the correct > > locks are returned or released on error. > > I don't see how this cleans up anything.. It ensures the correct flags are released in the error path without having to add the flag in the next patch in 2 places. Ira
