On Fri, Feb 21, 2020 at 06:49:59AM -0800, Christoph Hellwig wrote: > On Wed, Feb 19, 2020 at 05:43:43PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > Use the new uncached buffer functions to manage buffers instead of > > open-coding the logic. > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Isn't xfs_log_recover.c supposed to be partially shared with the kernel? > I guess I need to port over my changes to the buffer handling there, > which would mean implementing xfs_rw_bdev using preadv/pwritev. It ought to be, but the file has fallen very far out of sync with the kernel and I didn't want to launch a log recovery reconstruction project. This patch is useful to get us to the point of having one buffer api and using it consistently, but that's about it... --D