Re: [PATCH v2] xfs: add agf freeblocks verify in xfs_agf_verify

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Thu, Feb 20, 2020 at 07:13:02PM +0800, Zheng Bin wrote:
> +	if (be32_to_cpu(agf->agf_length) > mp->m_sb.sb_dblocks ||
> +	    be32_to_cpu(agf->agf_btreeblks) > be32_to_cpu(agf->agf_length) ||
> +	    be32_to_cpu(agf->agf_rmap_blocks) > be32_to_cpu(agf->agf_length) ||
> +	    be32_to_cpu(agf->agf_refcount_blocks) > be32_to_cpu(agf->agf_length) ||

This adds a > 80 char line, please properly format it.

> +	    be32_to_cpu(agf->agf_spare2) != 0)
> +		return __this_address;

There is no need to byte swap fields if you just check if they are
non-zero.

> +
> +	for (i = 0; i < ARRAY_SIZE(agf->agf_spare64); i++)
> +		if (be64_to_cpu(agf->agf_spare64[i]) != 0)
> +			return __this_address;

Same here.