On 2/17/20 10:49 PM, Zorro Lang wrote: > On Sat, Feb 08, 2020 at 03:09:19PM -0600, Eric Sandeen wrote: >> Quota timers are currently a mess. Right now, at mount time, >> we pick up the first enabled type and use that for the single >> timer in mp->m_quotainfo. >> >> Interestingly, if we set a timer on a different type, /that/ >> gets set into mp->m_quotainfo where it stays in effect until >> the next mount, when we pick the first enabled type again. >> >> We actually write the timer values to each type of quota inode, >> but only one is ever in force, according to the interesting behavior >> described above. >> >> This series allows quota timers & warn limits to be independently >> set and enforced for each quota type. >> >> All the action is in the last patch, the first 3 are cleanups to >> help. > > This patchset looks good, but the testing for xfs quota timers looks > not so well. Please check the emails(test case) I sent to fstests@: > [PATCH 1/2] generic: per-type quota timers set/get test > [PATCH 2/2] generic: test per-type quota softlimit enforcement timeout > > Why xfs has such different test results? Please feel free to tell me, > if the case is wrong. Thanks for this, Zorro, I'll take a look. -Eric > Thanks, > Zorro > >> >> -Eric >> >
