On Mon, Feb 17, 2020 at 01:59:56PM +0100, Christoph Hellwig wrote: > Now that we use the on-disk flags field also for the interface to the > lower level attr routines we can use the XFS_ATTR_INCOMPLETE definition > from the on-disk format directly instead. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Chandan Rajendra <chandanrlinux@xxxxxxxxx> > --- > fs/xfs/libxfs/xfs_attr.c | 2 +- > fs/xfs/libxfs/xfs_attr_leaf.c | 15 ++++++--------- > fs/xfs/libxfs/xfs_types.h | 6 ++---- > 3 files changed, 9 insertions(+), 14 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c > index d5c112b6dcdd..23e0d8ce39f8 100644 > --- a/fs/xfs/libxfs/xfs_attr.c > +++ b/fs/xfs/libxfs/xfs_attr.c > @@ -898,7 +898,7 @@ xfs_attr_node_addname( > * The INCOMPLETE flag means that we will find the "old" > * attr, not the "new" one. > */ > - args->op_flags |= XFS_DA_OP_INCOMPLETE; > + args->attr_namespace |= XFS_ATTR_INCOMPLETE; So args->attr_namespace is no longer an indication of what attribute namespace to look up? Unless you are now defining incomplete attributes to be in a namespace? If so, I think this needs more explanation than "we can use the on-disk format directly instead". That's just telling me what the patch is doing and doesn't explain why we are considering this specific on disk flag to indicate a new type of "namespace" for attributes lookups. Hence I think this needs more documentation in both the commit and the code as the definition of XFS_ATTR_INCOMPLETE doesn't really make it clear that this is now considered a namespace signifier... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
