On Mon, Feb 17, 2020 at 01:59:41PM +0100, Christoph Hellwig wrote: > Use a NULL args->value as the indicator to lazily allocate a buffer > instead, and let the caller always free args->value instead of > duplicating the cleanup. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Chandan Rajendra <chandanrlinux@xxxxxxxxx> > --- > fs/xfs/libxfs/xfs_attr.c | 20 +++++--------------- > fs/xfs/libxfs/xfs_attr.h | 7 ++----- > fs/xfs/libxfs/xfs_attr_leaf.c | 2 +- > fs/xfs/libxfs/xfs_types.h | 2 -- > fs/xfs/xfs_acl.c | 20 ++++++++++---------- > 5 files changed, 18 insertions(+), 33 deletions(-) looks ok. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx
