On Mon, Feb 17, 2020 at 01:59:27PM +0100, Christoph Hellwig wrote: > While the flags field in the ABI and the on-disk format allows for > multiple namespace flags, that is a logically invalid combination and > listing multiple namespace flags will return no results as no attr > can have both set. Reject this case early with -EINVAL. Had a bit of a hard time deciphering this. Perhaps: While the flags field in the ABI and the on-disk format allows for multiple namespace flags, an attribute can only exist in a single namespace at a time. Hence asking to list attributes that exist in multiple namespaces simultaneously is a logically invalid request and will return no results. Reject this case early with -EINVAL. Other than that, the code is good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx
