On Tue, Feb 04, 2020 at 04:47:09PM -0800, Darrick J. Wong wrote: > + rootino = libxfs_ialloc_calc_rootino(mp, mp->m_sb.sb_unit); > > + validate_sb_ino(&mp->m_sb.sb_rootino, rootino, > _("root")); > + validate_sb_ino(&mp->m_sb.sb_rbmino, rootino + 1, > _("realtime bitmap")); > + validate_sb_ino(&mp->m_sb.sb_rsumino, rootino + 2, I think the first two calls don't need to be split over two lines. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>