On Mon, Feb 10, 2020 at 12:15:34PM +0530, Chandan Rajendra wrote: > > error = xfs_attr_set(&args); > > - if (!error) > > - xfs_forget_acl(inode, name, args.flags); > > + if (!error && (flags & ATTR_ROOT)) > > ATTR_ROOT should be checked against args.flags. > > 'flags' refers to argument passed to setxattr() syscall i.e. it can have > XATTR_CREATE or XATTR_REPLACE as its value. Fixed, thanks.