On Fri, Feb 07, 2020 at 03:12:06PM +0530, Chandan Rajendra wrote:
> > struct inode *inode, const char *name, const void *value,
> > size_t size, int flags)
> > {
> > - int xflags = handler->flags;
> > - struct xfs_inode *ip = XFS_I(inode);
> > + struct xfs_da_args args = {
> > + .dp = XFS_I(inode),
> > + .flags = handler->flags,
> > + .name = name,
> > + .namelen = strlen(name),
> > + .value = (unsigned char *)value,
>
> Since xfs_da_args.value is of type "void *', Wouldn't it be more uniform if
> 'value' is typecasted with (void *)?
Yes, fixed.
