On Wednesday, February 12, 2020 8:41 PM Brian Foster wrote: > On Wed, Jan 29, 2020 at 10:29:38AM +0530, Chandan Rajendra wrote: > > This commit changes xfs_attr_leaf_newentsize() to explicitly accept name and > > value length instead of a pointer to struct xfs_da_args. The next commit will > > need to invoke xfs_attr_leaf_newentsize() from functions that do not have > > a struct xfs_da_args to pass in. > > > > Signed-off-by: Chandan Rajendra <chandanrlinux@xxxxxxxxx> > > --- > > fs/xfs/libxfs/xfs_attr.c | 3 ++- > > fs/xfs/libxfs/xfs_attr_leaf.c | 41 ++++++++++++++++++++++++----------- > > fs/xfs/libxfs/xfs_attr_leaf.h | 3 ++- > > 3 files changed, 32 insertions(+), 15 deletions(-) > > > ... > > diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c > > index 08d4b10ae2d53..7cd57e5844d80 100644 > > --- a/fs/xfs/libxfs/xfs_attr_leaf.c > > +++ b/fs/xfs/libxfs/xfs_attr_leaf.c > ... > > @@ -2687,20 +2700,22 @@ xfs_attr_leaf_entsize(xfs_attr_leafblock_t *leaf, int index) > > */ > > int > > xfs_attr_leaf_newentsize( > > - struct xfs_da_args *args, > > + struct xfs_mount *mp, > > Any reason not to just pass the geo here rather than the mount? > Otherwise looks fine to me. Sorry, I noticed this message now. You are right. I will change the first argument to be attr geometry pointer. -- chandan
