On Tue, Feb 11, 2020 at 11:10:17PM +0100, Pavel Reichl wrote:
> In its current form, xfs_isilocked() is only able to test one lock type at a
> time - ilock, iolock, or mmap lock, but combinations are not properly handled.
> The intent here is to check that both XFS_IOLOCK_EXCL and XFS_ILOCK_EXCL are
> held, so test them each separately.
>
> The commit ecfea3f0c8c6 ("xfs: split xfs_bmap_shift_extents") ORed the flags
> together which was an error, so this patch reverts that part of the change and
> check the locks independently.
Commit message should wrap at 68-72 columns.
> Fixes: ecfea3f0c8c6 ("xfs: split xfs_bmap_shift_extents")
>
> Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> Suggested-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Signed-off-by: Pavel Reichl <preichl@xxxxxxxxxx>
> ---
> Changelog from V3:
> Commit message extened.
Same comment as the previous patch about the subject - "fix" and
abbreviations.
xfs: xfs_isilocked() can only check a single lock type
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
