On Wednesday, January 29, 2020 10:33 PM Christoph Hellwig wrote:
> Remove superflous braces, elses after return statements and use a goto
> label to merge common error handling.
>
The changes look good to me,
Reviewed-by: Chandan Rajendra <chandanrlinux@xxxxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---
> fs/xfs/libxfs/xfs_attr.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
> index 3b1db2afb104..9c629c7c912d 100644
> --- a/fs/xfs/libxfs/xfs_attr.c
> +++ b/fs/xfs/libxfs/xfs_attr.c
> @@ -423,9 +423,9 @@ xfs_attr_shortform_addname(xfs_da_args_t *args)
> trace_xfs_attr_sf_addname(args);
>
> retval = xfs_attr_shortform_lookup(args);
> - if ((args->flags & ATTR_REPLACE) && (retval == -ENOATTR)) {
> + if ((args->flags & ATTR_REPLACE) && retval == -ENOATTR)
> return retval;
> - } else if (retval == -EEXIST) {
> + if (retval == -EEXIST) {
> if (args->flags & ATTR_CREATE)
> return retval;
> retval = xfs_attr_shortform_remove(args);
> @@ -489,14 +489,11 @@ xfs_attr_leaf_addname(
> * the given flags produce an error or call for an atomic rename.
> */
> retval = xfs_attr3_leaf_lookup_int(bp, args);
> - if ((args->flags & ATTR_REPLACE) && (retval == -ENOATTR)) {
> - xfs_trans_brelse(args->trans, bp);
> - return retval;
> - } else if (retval == -EEXIST) {
> - if (args->flags & ATTR_CREATE) { /* pure create op */
> - xfs_trans_brelse(args->trans, bp);
> - return retval;
> - }
> + if ((args->flags & ATTR_REPLACE) && retval == -ENOATTR)
> + goto out_brelse;
> + if (retval == -EEXIST) {
> + if (args->flags & ATTR_CREATE) /* pure create op */
> + goto out_brelse;
>
> trace_xfs_attr_leaf_replace(args);
>
> @@ -637,6 +634,9 @@ xfs_attr_leaf_addname(
> error = xfs_attr3_leaf_clearflag(args);
> }
> return error;
> +out_brelse:
> + xfs_trans_brelse(args->trans, bp);
> + return retval;
> }
>
> /*
> @@ -763,9 +763,9 @@ xfs_attr_node_addname(
> goto out;
> blk = &state->path.blk[ state->path.active-1 ];
> ASSERT(blk->magic == XFS_ATTR_LEAF_MAGIC);
> - if ((args->flags & ATTR_REPLACE) && (retval == -ENOATTR)) {
> + if ((args->flags & ATTR_REPLACE) && retval == -ENOATTR)
> goto out;
> - } else if (retval == -EEXIST) {
> + if (retval == -EEXIST) {
> if (args->flags & ATTR_CREATE)
> goto out;
>
>
--
chandan
