On Wednesday, January 29, 2020 10:32 PM Christoph Hellwig wrote: > All the callers already check the length when allocating the > in-kernel xattrs buffers. > I checked all the callers apart from xfs_init_security(). For the ones I checked, Reviewed-by: Chandan Rajendra <chandanrlinux@xxxxxxxxx> > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > fs/xfs/libxfs/xfs_attr.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c > index a968158b9bb1..f887d62e0956 100644 > --- a/fs/xfs/libxfs/xfs_attr.c > +++ b/fs/xfs/libxfs/xfs_attr.c > @@ -72,9 +72,6 @@ xfs_attr_args_init( > args->flags = flags; > args->name = name; > args->namelen = namelen; > - if (args->namelen >= MAXNAMELEN) > - return -EFAULT; /* match IRIX behaviour */ > - > args->hashval = xfs_da_hashname(args->name, args->namelen); > return 0; > } > -- chandan
