> zonefs is a very simple file system … How do you think about to be consistent with the capitalisation at the beginning of such sentences? https://lore.kernel.org/linux-fsdevel/20200206052631.111586-1-damien.lemoal@xxxxxxx/ … > +++ b/fs/zonefs/super.c … > +static int zonefs_create_zgroup(struct zonefs_zone_data *zd, > + enum zonefs_ztype type) > +{ … > + if (type == ZONEFS_ZTYPE_CNV) > + zgroup_name = "cnv"; > + else > + zgroup_name = "seq"; I find the following code variant more succinct. + zgroup_name = (type == ZONEFS_ZTYPE_CNV) ? "cnv" : "seq"; Regards, Markus
