https://bugzilla.kernel.org/show_bug.cgi?id=206429 Eric Sandeen (sandeen@xxxxxxxxxxx) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandeen@xxxxxxxxxxx --- Comment #1 from Eric Sandeen (sandeen@xxxxxxxxxxx) --- The patch is not quite the right approach - the get label command sets both DB_OPTS and IO_OPTS, as does the set label command, and your patch would make it fall back to xfs_db for both, which will then fail to set a label on a mounted filesystem: # db/xfs_admin.sh -L foobar mnt xfs_admin: cannot open mnt: Is a directory # sh -x db/xfs_admin.sh -L foobar mnt ... + eval xfs_db -x -p xfs_admin -c ''\''label' 'foobar'\''' mnt ++ xfs_db -x -p xfs_admin -c 'label foobar' mnt xfs_admin: cannot open mnt: Is a directory xfs_admin has become convoluted/complicated, let me give this some thought. Thanks for the report, -Eric -- You are receiving this mail because: You are watching the assignee of the bug.
