> - ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL)); > + ASSERT(xfs_is_ilocked(ip, XFS_ILOCK_EXCL)); I think this is a very bad interface. Either we keep our good old xfs_isilocked that just operates on the inode and lock flags, or we use something that gets the actual lock passed. But an interface that encodes the lock in both the function called and the flags, and one that doesn't follow neither the XFS lock flags conventions nor the core kernel convention is just not very useful.
