Re: [PATCH 6/6] xfs: remove XFS_BUF_TO_SBP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 03, 2020 at 12:38:34PM -0600, Eric Sandeen wrote:
> > @@ -707,7 +707,7 @@ xfs_sb_read_verify(
> >  	 * Check all the superblock fields.  Don't byteswap the xquota flags
> >  	 * because _verify_common checks the on-disk values.
> >  	 */
> > -	__xfs_sb_from_disk(&sb, XFS_BUF_TO_SBP(bp), false);
> > +	__xfs_sb_from_disk(&sb, bp->b_addr, false);
> 
> why not dsb here

Yes, this should just pass dsb.

> In any case seems like if you already have a local xfs_dsb, use that vs.
> bp->b_addr?

That was the planned, but I obviously missed one spot.



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux