On 1/30/20 1:45 PM, Eric Sandeen wrote: > On 1/23/20 6:17 PM, Darrick J. Wong wrote: >> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> >> >> Refactor the checking and resetting of fixed-location inodes (root, >> rbmino, rsumino) into a helper function. >> >> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Looks good, though it might mess with translations a bit? > > Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx> Actually, would you mind if I changed "ensure_fixed_ino" to something like "check_inode_loc" or "validate_inode_nr" ... I don't know what it means to "ensure" an inode. :) Not a huge deal but if there's something more descriptive, let's use it. -Eric
