OK, thank you for your opinion. :-) On Thu, Jan 30, 2020 at 2:31 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Thu, Jan 30, 2020 at 09:57:02AM +0100, Pavel Reichl wrote: > > the changes are divided into three patches so the changes are really > > obvious and each patch does just one thing...it was actually an extra > > effort to separate the changes but if there's an agreement that it > > does not add any value then I can squash them into one - no problem > > ;-) > > Well, they make the change a lot less obvious. After we have some form > of patch 1, mrlocks are just a pointless wrapper. Removing it in one > go is completely obvious - splitting it in 3 patches with weird > inbetween states is everything but. >
