On Wed, Jan 29, 2020 at 01:47:49PM -0600, Eric Sandeen wrote: > V3: ditto, plus enforce -fno-common so older gcc users will play > by the same rules as gcc 10 I don't mind adding -fno-common, but it has aboslutely nothing to do with removing pointless duplicate variable defintions. I'd say apply v2 and make this a separate patch. > @@ -13,7 +13,7 @@ OPTIMIZER = @opt_build@ > MALLOCLIB = @malloc_lib@ > LOADERFLAGS = @LDFLAGS@ > LTLDFLAGS = @LDFLAGS@ > -CFLAGS = @CFLAGS@ -D_FILE_OFFSET_BITS=64 > +CFLAGS = @CFLAGS@ -D_FILE_OFFSET_BITS=64 -fno-common Are there any compilers not supporting -fno-common? (And do we care?)
