On Mon, Jan 27, 2020 at 04:56:02PM -0600, Eric Sandeen wrote: > From: Eric Sandeen <sandeen@xxxxxxxxxx> > > In each of these cases, db, logprint, and mdrestore are redeclaring > as a global variable something which was already provided by a > library they link with. Independent of any better way to handle the library interaction this looks like an improvement on its own: Reviewed-by: Christoph Hellwig <hch@xxxxxx>