Re: [PATCH v9 1/2] fs: New zonefs file system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020/01/27 21:49, Markus Elfring wrote:
>
>> +++ b/fs/zonefs/super.c
>
>> +static char *zgroups_name[ZONEFS_ZTYPE_MAX] = { "cnv", "seq" };
> 
> Would you like to keep this array as mutable?
> How do you think about to mark such data structures as “const”?

Yes, good catch. Furthermore, since this array is used only in
zonefs_create_zgroup(), I moved its declaration on-stack in that function.

Thanks.

> 
> Regards,
> Markus
> 


-- 
Damien Le Moal
Western Digital Research




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux