Re: [PATCH 2/2] libxfs: move header includes closer to kernelspace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/25/20 5:15 PM, Christoph Hellwig wrote:
On Wed, Jan 22, 2020 at 10:48:51AM -0600, Eric Sandeen wrote:
Aid application of future kernel patches which change #includes;
not all headers exist in userspace so this is not a 1:1 match, but
it brings userspace files a bit closer to kernelspace by adding all
#includes which do match, and putting them in the same order.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Given how our headers are such a mess I wonder if we should reduce them
to something like just a handful.  Life would become a lot simpler..

IIRC we explicitly moved away from that at one point.  *shrug* not sure
what the best approach is but I don't want to keep oscillating.

-Eric




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux