Re: [PATCH 4/5] xfsprogs: remove the SIZEOF_LONG substitution in platform_defs.h.in

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 26, 2020 at 12:35:40PM +0100, Christoph Hellwig wrote:
> BITS_PER_LONG is now only checked in C expressions, so we can simply
> define it based on sizeof(long).
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

--D

> ---
>  include/platform_defs.h.in | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/platform_defs.h.in b/include/platform_defs.h.in
> index ff0a6a4e..36006cbf 100644
> --- a/include/platform_defs.h.in
> +++ b/include/platform_defs.h.in
> @@ -26,9 +26,7 @@
>  
>  typedef struct filldir		filldir_t;
>  
> -/* long and pointer must be either 32 bit or 64 bit */
> -#undef SIZEOF_LONG
> -#define BITS_PER_LONG (SIZEOF_LONG * CHAR_BIT)
> +#define BITS_PER_LONG (sizeof(long) * CHAR_BIT)
>  
>  /* Check whether to define umode_t ourselves. */
>  #ifndef HAVE_UMODE_T
> -- 
> 2.24.1
> 



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux