On Tue, Jan 21, 2020 at 10:41:40AM -0800, Darrick J. Wong wrote: > On Tue, Jan 14, 2020 at 09:10:42AM +0100, Christoph Hellwig wrote: > > The old xfs_attr_list code is only used by the attrlist by handle > > ioctl. Move it to xfs_ioctl.c with its user. Also move the > > attrlist and attrlist_ent structure to xfs_fs.h, as they are exposed > > user ABIs. > > They weren't there already? Gross.... > > > They are used through libattr headers with the same name > > by at least xfsdump. Also document this relation so that it doesn't > > require a research project to figure out. > > Shouldn't these two structures get a check in xfs_ondisk.h to make sure > that we don't accidentally break the structure size? These aren't on-disk but syscall ABI structures, and they actually differ in size on different architectures..
