Re: [PATCH 03/12] xfs: make xfs_buf_read_map return an error code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 23, 2020 at 09:19:15PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> Convert xfs_buf_read_map() to return numeric error codes like most
> everywhere else in xfs.  This involves moving the open-coded logic that
> reports metadata IO read / corruption errors and stales the buffer into
> xfs_buf_read_map so that the logic is all in one place.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---
>  fs/xfs/libxfs/xfs_alloc.c       |   11 ++++---
>  fs/xfs/libxfs/xfs_attr_remote.c |   10 ------
>  fs/xfs/xfs_buf.c                |   63 +++++++++++++++++++++++++++++----------
>  fs/xfs/xfs_buf.h                |   15 ++++++---
>  fs/xfs/xfs_log_recover.c        |   10 ------
>  fs/xfs/xfs_symlink.c            |   10 ------
>  fs/xfs/xfs_trans_buf.c          |   36 +++++-----------------
>  7 files changed, 72 insertions(+), 83 deletions(-)

Error handling in xfs_trans_read_buf_map() looks ok now.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux