Re: [PATCH 11/12] xfs: remove unnecessary null pointer checks from _read_agf callers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 22, 2020 at 11:43:01PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> Drop the null buffer pointer checks in all code that calls
> xfs_alloc_read_agf and doesn't pass XFS_ALLOC_FLAG_TRYLOCK because
> they're no longer necessary.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> ---
>  fs/xfs/libxfs/xfs_refcount.c   |    6 ------
>  fs/xfs/scrub/agheader_repair.c |    4 ----
>  fs/xfs/scrub/fscounters.c      |    3 ---
>  fs/xfs/scrub/repair.c          |    2 --
>  fs/xfs/xfs_discard.c           |    2 +-
>  fs/xfs/xfs_reflink.c           |    2 --
>  6 files changed, 1 insertion(+), 18 deletions(-)

looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux