On Wed, Jan 22, 2020 at 11:42:03PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Convert xfs_buf_read() to return numeric error codes like most > everywhere else in xfs. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > fs/xfs/libxfs/xfs_attr_remote.c | 8 ++++---- > fs/xfs/xfs_buf.h | 13 +++++++++++-- > fs/xfs/xfs_log_recover.c | 16 +++++++--------- > fs/xfs/xfs_symlink.c | 8 ++++---- > 4 files changed, 26 insertions(+), 19 deletions(-) Looks fine. All of the callers have exactly the same error handling, so this makes sense to pull that up into xfs_buf_read() as a first step. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx
