Re: [PATCH 11/29] xfs: pass an initialized xfs_da_args to xfs_attr_get

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 21, 2020 at 10:12:47AM -0800, Darrick J. Wong wrote:
> > - * If ATTR_KERNOVAL is set in @flags, then the caller does not want the value,
> > - * just an indication whether the attribute exists and the size of the value if
> > - * it exists. The size is returned in @valuelenp,
> > + * If ATTR_KERNOVAL is set in args->flags, then the caller does not want the
> 
> "...is set in @args->flags..." ?
> 
> (I mean... it's pretty obvious to a human that "args" refers to the
> parameter, but I dunno if the automated scanning tools are going to get
> all cranky if we don't @ it.)

This isn't a kerneldoc style comment, so no tool will parse it.  I'd
like to avoid strange annotations where not needed.



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux