On Tue, Jan 21, 2020 at 09:57:52AM -0800, Darrick J. Wong wrote: > On Tue, Jan 14, 2020 at 09:10:28AM +0100, Christoph Hellwig wrote: > > All callers provide a valid name pointer, remove the redundant check. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > Hm. I wondered if this should become at least an ASSERT(name != NULL) > to catch future users screwing that up, but I think the answer is that > we'll crash soon enough in xfs_da_hashname? Yes, passing a NULL name would blow up instantly and also doesn't really make sense to start with as you want to set/get something after all..
