On Tue, Jan 21, 2020 at 04:20:46PM -0800, Darrick J. Wong wrote: > I rearrange responsibility for dealing with buffer error handling in the > patch "xfs: move buffer read io error logging to xfs_buf_read_map" later > in this series. Was that not what you were expecting? I defintively don't expect a patch talking about logging to change error handling behavior. And yes, I also expect that if we change a function to return an error code that is actually uses that to return errors. > Though looking at that patch I guess we could set @error directly to the > return values of xfs_buf_reverify/_xfs_buf_read. Yes. Code outside xfs_buf.c and maybe xfs_buf_item.c really ever access b_error.
