Re: [PATCH 3/9] xfs: make xfs_buf_get return an error code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 3/9] xfs: make xfs_buf_get return an error code
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 16 Jan 2020 08:16:42 -0800
Cc: linux-xfs@xxxxxxxxxxxxxxx, hch@xxxxxxxxxxxxx
In-reply-to: <157910783855.2028217.9100808565121356587.stgit@magnolia>
References: <157910781961.2028217.1250106765923436515.stgit@magnolia> <157910783855.2028217.9100808565121356587.stgit@magnolia>

On Wed, Jan 15, 2020 at 09:03:58AM -0800, Darrick J. Wong wrote:
> -				 XFS_FSS_TO_BB(mp, 1));
> +				 XFS_FSS_TO_BB(mp, 1),
> +				 &bp);

Do we need the extra line here?

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Follow-Ups:
- Re: [PATCH 3/9] xfs: make xfs_buf_get return an error code
  - From: Darrick J. Wong

References:
- [PATCH 0/9] xfs: make buffer functions return error codes
  - From: Darrick J. Wong
- [PATCH 3/9] xfs: make xfs_buf_get return an error code
  - From: Darrick J. Wong

Prev by Date: Re: [PATCH 2/9] xfs: make xfs_buf_read return an error code
Next by Date: Re: [PATCH 4/9] xfs: make xfs_buf_get_uncached return an error code
Previous by thread: [PATCH 3/9] xfs: make xfs_buf_get return an error code
Next by thread: Re: [PATCH 3/9] xfs: make xfs_buf_get return an error code
Index(es):
- Date
- Thread

[Index of Archives] [XFS Filesystem Development (older mail)] [Linux Filesystem Development] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux RAID] [Linux SCSI]

Powered by Linux