On Wed, Jan 08, 2020 at 12:09:27AM -0800, Christoph Hellwig wrote: > > --- a/fs/xfs/libxfs/xfs_format.h > > +++ b/fs/xfs/libxfs/xfs_format.h > > @@ -1540,6 +1540,7 @@ typedef struct xfs_bmdr_block { > > #define BMBT_BLOCKCOUNT_BITLEN 21 > > > > #define BMBT_STARTOFF_MASK ((1ULL << BMBT_STARTOFF_BITLEN) - 1) > > +#define XFS_MAX_FILEOFF (BMBT_STARTOFF_MASK) > > I think throwing in a comment here would be useful. > > Otherwise the patch looks good to me. Ok, done. --D