On Mon, Jan 06, 2020 at 01:45:01PM -0800, Darrick J. Wong wrote: > On Mon, Jan 06, 2020 at 11:29:29AM -0700, Allison Collins wrote: > > > > > > On 1/6/20 7:46 AM, Brian Foster wrote: > > > On Wed, Dec 25, 2019 at 10:43:15AM -0700, Allison Collins wrote: > > > > > > > > > > > > On 12/24/19 5:14 AM, Christoph Hellwig wrote: > > > > > On Wed, Dec 11, 2019 at 09:15:04PM -0700, Allison Collins wrote: > > > > > > Break xfs_attr_rmtval_set into two helper functions > > > > > > xfs_attr_rmt_find_hole and xfs_attr_rmtval_set_value. > > > > > > xfs_attr_rmtval_set rolls the transaction between the > > > > > > helpers, but delayed operations cannot. We will use > > > > > > the helpers later when constructing new delayed > > > > > > attribute routines. > > > > > > > > > > Please use up the foll 72-ish characters for the changelog (also for > > > > > various other patches). > > > > Hmm, in one of my older reviews, we thought the standard line wrap length > > > > was 68. Maybe when more folks get back from holiday break, we can have more > > > > chime in here. > > > > > > > > > > I thought it was 68 as well (I think that qualifies as 72-ish" at > > > least), but the current commit logs still look short of that at a > > > glance. ;P > > > > > > Brian > > Ok I doubled checked, the last few lines do wrap a little early, but the > > rest is correct for 68 because of the function names. We should probably > > establish a number though. In perusing around some of the other patches on > > the list, it looks to me like people are using 81? > > I use 72 columns for emails and commit messages, and 79 for code. Typically 68-72 columns for commit messages, often 68 because git log output adds a 4 space indent to the commit message and that often gets quoted directly in email... > Though to be honest that's just my editor settings; I'm sure interested > parties could find plenty of instances where my enforcement of even that > is totally lax -- > > I have enough of a difficult time finding all the subtle bugs and corner > case design problems in the kernel code (which will cause problems in > our users' lives) that so long as you're not obviously going past the > flaming red stripe that I told vim to put at column 80, I don't really > care (because maxcolumns errors don't usually cause data loss). :) Yeah, I have the flaming red column set to 80 by default, 68 for email and commit messages... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
