On Mon, Dec 16, 2019 at 06:35:35PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Prepare to resync the userspace libxfs with the kernel libxfs. There > were a few things I missed -- a couple of static inline directory > functions that have to be exported for xfs_repair; a couple of directory > naming functions that make porting much easier if they're /not/ static > inline; and a u16 usage that should have been uint16_t. > > None of these things are bugs in their own right; this just makes > porting xfsprogs easier. Instead of exporting random low-level helpers can you please look into refactoring repair to not require such low level access. E.g. the put_ino helper seems to be mostly used for convert short form directories from and to the 8 byte inode format, for which we already have kernel helpers in a slighty different form. I'm also kinda pissed that this was rushed into mainline after -rc2 despite not fixing anything in the kernel. That is not how the development cycle is supposed to work.
