On 12/18/19 11:25 AM, Darrick J. Wong wrote: > On Wed, Dec 18, 2019 at 11:20:40AM -0600, Eric Sandeen wrote: >> On 12/18/19 11:09 AM, Darrick J. Wong wrote: >>> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> >>> >>> The section of the xfs_io manpage for the 'chattr' command says to refer >>> to xfsctl(3) for information on the flags. The inode flag information >>> was moved to ioctl_xfs_fssetxattr(2) ages ago, and it never actually >>> mapped the inode flag letters to inode flag bits, so add those to the >>> xfs_io manpage. >> >> Hm, ok. The info is in the command's help output but I suppose it's useful >> enough to have it in the (a?) manpage, too. >> >> OTOH this cuts & pastes quite a lot from the ioctl_xfs_fsgetxattr and I get >> nervous when we do that because it /will/ get out of sync. >> >> I wonder if we can just say "refer to help output for flag mappings, and to >> ioctl_xfs_fsgetxattr for flag descriptions?" >> >> Or would it suffice to just fix up the existing text: >> >> The mapping between each >> letter and the inode flags (refer to >> .BR ioctl_xfs_fssetxattr (2) >> for the full list) is available via the >> .B help >> command. > > Hmm, I guess that would work too? > > Or how about add the raw mapping from letter to flag in the manpage: > > "The inode flags are as follows: > o XFS_XFLAG_OSCAR > t XFS_XFLAG_THE > g XFS_XFLAG_GROUCH" I guess to tie it all together we could adopt the current help output descriptions, something like r realtime (XFS_XFLAG_REALTIME) i immutable (XFS_XFLAG_IMMUTABLE) a append-only ( ....) ... see ioctl_xfs_fsgetxattr for detailed flag descriptions. I dunno, or am I too averse to the cut & paste in the original patch? > ? :) > > /bikeshedding /waffling -Eric
