Hi, ----- Original Message ----- > From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> > To: "Eryu Guan" <guaneryu@xxxxxxxxx> > Cc: "Yang Xu" <xuyang2018.ky@xxxxxxxxxxxxxx>, "fstests" <fstests@xxxxxxxxxxxxxxx>, "xfs" <linux-xfs@xxxxxxxxxxxxxxx> > Sent: Wednesday, December 4, 2019 10:36:42 AM > Subject: [PATCH] xfs/148: sort attribute list output > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Yang Xu reported a test failure in xfs/148 that I think comes from > extended attributes being returned in a different order than they were > set. Since order isn't important in this test, sort the output to make > it consistent. > > Reported-by: Yang Xu <xuyang2018.ky@xxxxxxxxxxxxxx> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > tests/xfs/148 | 2 +- > tests/xfs/148.out | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/xfs/148 b/tests/xfs/148 > index 42cfdab0..ec1d0ece 100755 > --- a/tests/xfs/148 > +++ b/tests/xfs/148 > @@ -76,7 +76,7 @@ test_names+=("too_many" "are_bad/for_you") > > access_stuff() { > ls $testdir > - $ATTR_PROG -l $testfile > + $ATTR_PROG -l $testfile | grep 'a_' | sort > > for name in "${test_names[@]}"; do > ls "$testdir/f_$name" > diff --git a/tests/xfs/148.out b/tests/xfs/148.out > index c301ecb6..f95b55b7 100644 > --- a/tests/xfs/148.out > +++ b/tests/xfs/148.out > @@ -4,10 +4,10 @@ f_another > f_are_bad_for_you > f_something > f_too_many_beans > +Attribute "a_another" has a 3 byte value for TEST_DIR/mount-148/testfile > +Attribute "a_are_bad_for_you" has a 3 byte value for >From my test on RHEL8&RHEL7, when touch a file, there is a default attribute: Attribute "selinux" has a 37 byte value for TEST_DIR/mount-148/testfile Could you share the OS you test? Thanks. > TEST_DIR/mount-148/testfile > Attribute "a_something" has a 3 byte value for TEST_DIR/mount-148/testfile > Attribute "a_too_many_beans" has a 3 byte value for > TEST_DIR/mount-148/testfile > -Attribute "a_are_bad_for_you" has a 3 byte value for > TEST_DIR/mount-148/testfile > -Attribute "a_another" has a 3 byte value for TEST_DIR/mount-148/testfile > TEST_DIR/mount-148/testdir/f_something > Attribute "a_something" had a 3 byte value for TEST_DIR/mount-148/testfile: > heh > >