Re: [PATCH 4/4] xfs: Remove kmem_free()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Darrick.


> > > 
> > > Sure, but I'll believe that when I see it.  And given that Christoph
> > > Lameter seems totally opposed to the idea, I think we should keep our
> > > silly wrapper for a while to see if they don't accidentally revert it or
> > > something.
> > > 
> > 
> > Sure, I don't have any plans to do it now in this series or in a very near
> > future, I just used the email to share the idea :P
> 
> Eh, well, FWIW I took a second look at all the kvfree/kfree and decided
> that the usage was correct.  For future reference, please do the
> straight change as one patch and straighten out the usages as a separate
> patch.
> 

I'm not sure what you meant by 'straight change' and 'straighten out'.

Do you mean to do send a single patch with only the changes made by the
'find&replace' command, followed up by a kfree() -> kvfree() where appropriate?

Cheers.

> In any case it seemed to test ok over the weekend (and still seems ok
> with your series from today), so...
> Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 

> --D
> 
> > Thanks for the review.
> > 
> > -- 
> > Carlos
> > 
> 

-- 
Carlos





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux