On Tue, Nov 19, 2019 at 09:12:05AM -0800, Darrick J. Wong wrote: > Also, I forgot to mention that some of the comments (particularly > xfs_dabuf_map) need to be updated to reflect the new "no mapping" return > style since there's no more @mappedbno, etc. That is the one comment on xfs_dabuf_map, which in fact is already wrong in the current tree. When applying your changes I just removed the comment entirely as it is a static function with just two callers right below it.