> > > > I wonder if your version has struct xfs_dinode_v3 or it could avoid it. > > There is a benefit in terms of code complexity and test coverage > > to keep the only difference between inode versions in the on-disk > > parsers, while reading into the same struct, the same way as > > old inode versions are read into struct xfs_dinode. > > > > Oh well, I can wait for tomorrow to see the polished version :-) > > Well now we noticed that Arnd also changed the disk quota structure > format too, so that'll slow things down as we try to figure out how to > reconcile 34-bit inode seconds vs. 40-bit quota timer seconds. > > (Or whatever happens with that) > Sigh. FWIW, I liked Arnd's 40-bit inode time patch because it keeps the patch LoC for this conversion minimal. I am *not* promoting backward compat migration, but using the most of existing on-disk/in-core parser code and only adding parsing of new fields in inode format v4 reduces code complexity and improves test coverage. Please let me know if there is anything I can do to help pushing things forward. Thanks, Amir.
