On Thu, Nov 14, 2019 at 06:30:25AM +0100, Pavel Reichl wrote: > Yes Dave, but IIRC the patch failed to apply cleanly so I had to use > the -3way option and I got the idea that me merging code manually > voids your ACK :-) It depends. If the code itself is unchanged and it's just merge noise, then updating doesn't invalidate the review. If you had to change the code/logic because it no longer worked, then it's fair to ask for it to be reviewed again. :) Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
