On Thu, Nov 07, 2019 at 11:49:07PM -0800, Darrick J. Wong wrote: > On Fri, Nov 08, 2019 at 07:50:32AM +0100, Christoph Hellwig wrote: > > On Thu, Nov 07, 2019 at 10:48:01PM -0800, Darrick J. Wong wrote: > > > On Fri, Nov 08, 2019 at 06:23:03AM +0100, Christoph Hellwig wrote: > > > > Thes ioctls set DMAPI specific flags in the on-disk inode, but there is > > > > no way to actually ever query those flags. The only known user is > > > > xfsrestore with the -D option, which is documented to be only useful > > > > inside a DMAPI enviroment, which isn't supported by upstream XFS. > > > > > > Hmm, shouldn't we deprecate this at least for one or two releases? > > > > > > Even if it's functionally pointless... > > > > It sets a value we can't even retreive. Not sure what the deprecation > > would help with. > > Dotting i's and crossing t's. IOWs, not getting ourselves yelled at for > killing something without any warning / bureaucracy. :/ OTOH Dave said the same thing, so: Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --D > --D
