On Tue, Nov 12, 2019 at 08:24:21AM -0800, Darrick J. Wong wrote: > On Sun, Oct 20, 2019 at 10:21:44AM +0200, Christoph Hellwig wrote: > > We have the exact same memset in xfs_inode_alloc, which is always called > > just before xfs_iread. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > Seems fine on its own, but then I looked at all the zero initializers > and memsets in xfs_inode_alloc and wondered why we don't just > kmem_zone_zalloc the inode? Because kmem_zone_zalloc doesn't interact well with the rcu lookup schemes and the constructor. That being said I have some plans for this area as part of getting rid of the "dinode core" later on.
